[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 02/26] qcow2: Add refcount_bits to format-spe
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 02/26] qcow2: Add refcount_bits to format-specific info |
Date: |
Wed, 10 Dec 2014 15:14:18 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Dec 03, 2014 at 02:37:22PM +0100, Max Reitz wrote:
> Add the bit width of every refcount entry to the format-specific
> information.
>
> In contrast to lazy_refcounts and the corrupt flag, this should be
> always emitted, even for compat=0.10 although it does not support any
> refcount width other than 16 bits. This is because if a boolean is
> optional, one normally assumes it to be false when omitted; but if an
> integer is not specified, it is rather difficult to guess its value.
>
> This new field breaks some test outputs, fix them.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2.c | 4 +++-
> qapi/block-core.json | 5 ++++-
> tests/qemu-iotests/060.out | 1 +
> tests/qemu-iotests/065 | 23 +++++++++++++++--------
> tests/qemu-iotests/067.out | 5 +++++
> tests/qemu-iotests/082.out | 7 +++++++
> tests/qemu-iotests/089.out | 2 ++
> 7 files changed, 37 insertions(+), 10 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpCCHm7DS6UU.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v4 00/26] qcow2: Support refcount orders != 4, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 01/26] qcow2: Add two new fields to BDRVQcowState, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 02/26] qcow2: Add refcount_bits to format-specific info, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 03/26] qcow2: Do not return new value after refcount update, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 04/26] qcow2: Only return status from qcow2_get_refcount, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 05/26] qcow2: Use unsigned addend for update_refcount(), Max Reitz, 2014/12/03