[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-iotests: Skip 099 for VMDK subformats with
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-iotests: Skip 099 for VMDK subformats with desc file |
Date: |
Wed, 03 Dec 2014 09:30:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 2014-12-03 at 02:49, Fam Zheng wrote:
VMDK extent parsing code doesn't handle the JSON file name, so the case
fails for these subformats. Disabled them.
Signed-off-by: Fam Zheng <address@hidden>
---
tests/qemu-iotests/099 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/099 b/tests/qemu-iotests/099
index ffc7ea7..fb920fe 100755
--- a/tests/qemu-iotests/099
+++ b/tests/qemu-iotests/099
@@ -44,7 +44,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
_supported_fmt qcow qcow2 qed vdi vhdx vmdk vpc
_supported_proto file
_supported_os Linux
-
+_unsupported_imgopts "subformat=monolithicFlat" "subformat=twoGbMaxExtentFlat"
\
+ "subformat=twoGbMaxExtentSparse"
function do_run_qemu()
{
This is most certainly necessary, therefore: Thanks, applied to my
block-next tree:
https://github.com/XanClic/qemu/commits/block-next
However, as I said in our private email exchange, we need to fix the
error message, too.
$ qemu-img create -f vmdk -o subformat=monolithicFlat test.vmdk 64M
Formatting 'test.vmdk', fmt=vmdk size=67108864 compat6=off
subformat='monolithicFlat'
$ qemu-io -c 'open -o
file.driver=blkdebug,file.image.filename=test.vmdk,file.inject-error.0.event=read_aio'
qemu-io: can't open: Could not parse the JSON options
That's not very helpful. I'll send a patch for that.
Max