[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 1/3] qemu-img bench
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH 1/3] qemu-img bench |
|
Date: |
Fri, 28 Nov 2014 11:49:53 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Nov 26, 2014 at 03:46:42PM +0100, Kevin Wolf wrote:
> + while (data.n > 0) {
> + main_loop_wait(false);
> + }
Why is this false (non-blocking)? This is why you get the main loop
spun warning message.
Using true (blocking) seems like the right thing. data.n changes as
part of the callback, which is invoked from the main loop. There is no
need to be non-blocking.
Stefan
pgp5BmK3IaQeB.pgp
Description: PGP signature