qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv3 3/6] block: add a knob to disable multiwrite_m


From: Peter Lieven
Subject: Re: [Qemu-devel] [PATCHv3 3/6] block: add a knob to disable multiwrite_merge
Date: Thu, 27 Nov 2014 10:32:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

On 31.10.2014 11:59, Stefan Hajnoczi wrote:
On Fri, Oct 31, 2014 at 09:31:53AM +0100, Peter Lieven wrote:
Am 28.10.2014 um 12:11 schrieb Stefan Hajnoczi:
On Sat, Oct 25, 2014 at 06:55:50PM +0200, Peter Lieven wrote:
The big question is whether these user-visible interfaces make sense if
write merging will be moved from block.c into virtio-blk.c in the
future.  Once an interface has been added it cannot be removed.
Would you make it a feature of the virtio-blk-pci device then?
No, I myself feel that it is a generic feature and moving it into the
storage controller emulation code would be a step backwards.

As noone else seems to have a strong opinion here I would go for
making bdrv_multiwrite a bdrv_multireq and adjust everything accordingly?

Ok?

Peter




reply via email to

[Prev in Thread] Current Thread [Next in Thread]