Re: [Qemu-devel] [PATCH] input: move input-send-event into experimental namespace

[Markus Armbruster]

Markus Armbruster <address@hidden> writes:

> Amos Kong <address@hidden> writes:
>
>> On Tue, Nov 25, 2014 at 09:06:34AM +0100, Markus Armbruster wrote:
>>> Gerd Hoffmann <address@hidden> writes:
>>> 
>>> > Ongoing discussions on how we are going to specify the console,
>>> > so tag the command as experiemntal so we can refine things in
>>> > the 2.3 development cycle.
>>> >
>>> > Signed-off-by: Gerd Hoffmann <address@hidden>
>>> > ---
>>> >  qmp-commands.hx | 12 ++++++------
>>> 
>>> Don't you need to patch qapi-schema.json, too?
>>
>> Not necessary in function level.
>
> s/need to/want to/?
>
> For consistency, especially because the QAPI schema also serves as QMP
> command documentation.
>
>>> Do we actually explain "x- means experimental" anywhere?
>>
>> What's the official way to make command experimental?
>
> I think we have an understanding / convention that an "x-" prefix marks
> names as unstable API.  But I can't find it spelled out anywhere.
> Anyway, separate issue.
>
>> Quote from qapi-schema.json:
>> | # Notes: This command is experimental and may change
>> | syntax in future releases.
>
> Next to the return type ObjectTypeInfo rathe than the command
> qom-list-types, blech.

I went with "Note: this command is experimental, and not a stable API",
following precedence in qemu-options.hx.