Re: [Qemu-devel] [PATCH] input: improve docs for input-send-event qmp command

[Markus Armbruster]

Gerd Hoffmann <address@hidden> writes:

> On Fr, 2014-11-21 at 12:59 +0100, Markus Armbruster wrote:
>> [Copying Eric]
>> 
>> Gerd Hoffmann <address@hidden> writes:
>> 
>> > Text partly suggested by Markus Armbruster <address@hidden>
>> >
>> > Signed-off-by: Gerd Hoffmann <address@hidden>
>> > ---
>> >  qapi-schema.json | 12 ++++++++++++
>> >  1 file changed, 12 insertions(+)
>> >
>> > diff --git a/qapi-schema.json b/qapi-schema.json
>> > index d0926d9..fcd49b1 100644
>> > --- a/qapi-schema.json
>> > +++ b/qapi-schema.json
>> > @@ -3250,6 +3250,18 @@
>> >  # Send input event(s) to guest.
>> >  #
>> >  # @console: #optional console to send event(s) to.
>> > +#           This parameter can be used to send the input event to
>> > +#           specific input devices in case (a) multiple input devices
>> > +#           of the same kind are added to the virtual machine and (b)
>> > +#           you have configured input routing (see docs/multiseat.txt)
>> > +#           for those input devices.  If input routing is not
>> > +#           configured this parameter has no effect.
>> > +#           If @console is missing, only devices that aren't associated
>> > +#           with a console are admissible.
>> > +#           If @console is specified, it must exist, and both devices
>> > +#           associated with that console and devices not associated with a
>> > +#           console are admissible, but the former take precedence.
>> > +
>> >  #
>> >  # @events: List of InputEvent union.
>> >  #
>> 
>> What is a "console", and how get input devices assoated with one?  I
>> checked docs/multiseat.txt for clues, but found none.
>
> Oh, right, in the command line the video device names are used.  video
> device emulation actually creates the consoles, typically console 0 is
> your vga.  They are numbered in creation order.  You can inspect them in
> the qom tree (/backend/console[$nr]).  There is a device link pointing
> to the device which created it.

Begs the question why we're using console numbers in one place (QMP) and
qdev IDs in another (command line).  Why can't we use one of them
everywhere?  Or maybe support both everywhere?

As long as we have both, documentation needs to stitch them together.
Your explanation is a start, but it needs to be in a patch, not just in
a mailing list archive :)

I feel we better figure this out before the release, to avoid getting
stuck with a sub-par interface.