[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v2 2/2] migration: Implement multiple compression thre
From: |
Li, Liang Z |
Subject: |
Re: [Qemu-devel] [v2 2/2] migration: Implement multiple compression threads |
Date: |
Fri, 21 Nov 2014 07:38:45 +0000 |
> > +int migrate_compress_threads(void)
> > +{
> > + MigrationState *s;
> > +
> > + s = migrate_get_current();
> > +
> > + return s->compress_thread_count;
> > +}
> > +
> > int migrate_use_xbzrle(void)
> > {
> > MigrationState *s;
> > @@ -697,4 +795,5 @@ void migrate_fd_connect(MigrationState *s)
> >
> > qemu_thread_create(&s->thread, "migration", migration_thread, s,
> > QEMU_THREAD_JOINABLE);
> > + migrate_compress_threads_create(s);
> don't create compress_threads always.
> It may be better:
> if (!migrate_use_xbzrle()) {
> migrate_compress_threads_create(s);
> }
Thanks for your comments, in fact, the multiple thread compression can co-work
with xbrzle, which can help to accelerate live migration.
> BTW, this patch is too big to review. Spliting it into some patch will be
> welcome.
I am doing it.
- Re: [Qemu-devel] [v2 1/2] docs: Add a doc about multiple compression threads, (continued)
- [Qemu-devel] [v2 2/2] migration: Implement multiple compression threads, Li Liang, 2014/11/06
- Re: [Qemu-devel] [v2 2/2] migration: Implement multiple compression threads, Eric Blake, 2014/11/06
- Re: [Qemu-devel] [v2 2/2] migration: Implement multiple compression threads, Dr. David Alan Gilbert, 2014/11/06
- Re: [Qemu-devel] [v2 2/2] migration: Implement multiple compression threads, ChenLiang, 2014/11/21
- Re: [Qemu-devel] [v2 2/2] migration: Implement multiple compression threads,
Li, Liang Z <=
- Re: [Qemu-devel] [v2 2/2] migration: Implement multiple compression threads, ChenLiang, 2014/11/21
- Re: [Qemu-devel] [v2 2/2] migration: Implement multiple compression threads, Li, Liang Z, 2014/11/21
- Re: [Qemu-devel] [v2 2/2] migration: Implement multiple compression threads, ChenLiang, 2014/11/21
- Re: [Qemu-devel] [v2 2/2] migration: Implement multiple compression threads, ChenLiang, 2014/11/21