[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 13/22] progress: Allow regressing progress
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 13/22] progress: Allow regressing progress |
Date: |
Thu, 20 Nov 2014 15:29:22 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/20/2014 10:06 AM, Max Reitz wrote:
> Progress may regress; this should be displayed correctly by
> qemu_progress_print().
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> util/qemu-progress.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/util/qemu-progress.c b/util/qemu-progress.c
> index 4ee5cd0..c0fb14d 100644
> --- a/util/qemu-progress.c
> +++ b/util/qemu-progress.c
> @@ -152,6 +152,7 @@ void qemu_progress_print(float delta, int max)
> state.current = current;
>
> if (current > (state.last_print + state.min_skip) ||
> + current < (state.last_print - state.min_skip) ||
> (current == 100) || (current == 0)) {
Maybe we can drop the redundant () as long as we are touching this area
of code? But not worth a respin.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 09/22] qcow2: Open images with refcount order != 4, (continued)
- [Qemu-devel] [PATCH v3 09/22] qcow2: Open images with refcount order != 4, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 10/22] qcow2: refcount_order parameter for qcow2_create2, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 12/22] qcow2: Allow creation with refcount order != 4, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 11/22] iotests: Prepare for refcount_width option, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 13/22] progress: Allow regressing progress, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 16/22] qcow2: Use abort() instead of assert(false), Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 15/22] qcow2: Use error_report() in qcow2_amend_options(), Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 14/22] block: Add opaque value to the amend CB, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 17/22] qcow2: Split upgrade/downgrade paths for amend, Max Reitz, 2014/11/20
- [Qemu-devel] [PATCH v3 18/22] qcow2: Use intermediate helper CB for amend, Max Reitz, 2014/11/20