|
From: | zhanghailiang |
Subject: | Re: [Qemu-devel] [PATCH v2 0/3] fix bug about balloon working incorrectly when hotplug memeory |
Date: | Mon, 17 Nov 2014 18:53:24 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
On 2014/11/17 18:39, Michael S. Tsirkin wrote:
On Mon, Nov 17, 2014 at 01:11:07PM +0800, zhanghailiang wrote:Hi, Patch 1 and 2 mainly fix bug about balloon not working correctly when we do hotplug memory. It takes 'ram_size' as VM's real RAM size which is wrong after we hotplug memory. This bug exists since we begin to support hotplug memory, and it is better to fix it. Patch 3 add some trace events, it helps debugging balloon. If it is unnecessary, pls feel free to remove it. Thanks, zhanghailiangWhat about other users of ram_size? Are they all incorrect?
pc-dimm is only supported in x86 target now, and i am not quite sure if hotplug memory will break migration. I'll look into it. Thanks.
v2: - fix compiling break for other targets that don't support pc-dimm zhanghailiang (3): pc-dimm: add a function to calculate VM's current RAM size virtio-balloon: Fix balloon not working correctly when hotplug memory virtio-balloon: Add some trace events hw/mem/pc-dimm.c | 26 ++++++++++++++++++++++++++ hw/virtio/virtio-balloon.c | 21 +++++++++++++++------ include/exec/cpu-common.h | 1 + stubs/qmp_pc_dimm_device_list.c | 5 +++++ trace-events | 4 ++++ 5 files changed, 51 insertions(+), 6 deletions(-) -- 1.7.12.4.
[Prev in Thread] | Current Thread | [Next in Thread] |