[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2.3 8/8] tcg: Remove unused opcodes
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 2.3 8/8] tcg: Remove unused opcodes |
Date: |
Fri, 14 Nov 2014 15:47:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/14/2014 04:31 PM, Bastian Koppelmann wrote:
>
> On 11/11/2014 04:24 PM, Richard Henderson wrote:
>> diff --git a/tci.c b/tci.c
>> index 4711ee4..28292b3 100644
>> --- a/tci.c
>> +++ b/tci.c
>> @@ -506,19 +506,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t
>> *tb_ptr)
>> tb_ptr += 2;
>> switch (opc) {
>> - case INDEX_op_end:
>> - case INDEX_op_nop:
>> - break;
>> - case INDEX_op_nop1:
>> - case INDEX_op_nop2:
>> - case INDEX_op_nop3:
>> - case INDEX_op_nopn:
>> - case INDEX_op_discard:
>> - TODO();
>> - break;
>> - case INDEX_op_set_label:
>> - TODO();
>> - break;
> Why do you remove the TODO notice for INDEX_op_discard/set_label? Is TCI no
> longer maintained?
Barely. But these opcodes never reach this far anyway, so the todo is bogus.
r~
- Re: [Qemu-devel] [PATCH 2.3 4/8] tcg: Introduce tcg_op_buf_count and tcg_op_buf_full, (continued)
- [Qemu-devel] [PATCH 2.3 5/8] tcg: Put opcodes in a linked list, Richard Henderson, 2014/11/11
- [Qemu-devel] [PATCH 2.3 6/8] tcg: Remove opcodes instead of noping them out, Richard Henderson, 2014/11/11
- [Qemu-devel] [PATCH 2.3 7/8] tcg: Implement insert_op_before, Richard Henderson, 2014/11/11
- [Qemu-devel] [PATCH 2.3 8/8] tcg: Remove unused opcodes, Richard Henderson, 2014/11/11
- [Qemu-devel] [PATCH 2.3 1/8] tcg: Move some opcode generation functions out of line, Richard Henderson, 2014/11/11
- Re: [Qemu-devel] [PATCH 2.3 0/8] Linked list for tcg ops, Bastian Koppelmann, 2014/11/14