[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch |
|
Date: |
Thu, 13 Nov 2014 11:20:09 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Nov 12, 2014 at 06:48:18PM +0000, Gary Hook wrote:
> - return qemu_ftell(f) - last_ftell;
> + delta_ftell = qemu_ftell(f) - last_ftell;
> + return( (delta_ftell > 0) ? 1 : (delta_ftell < 0) ? -1 : 0 );
Good find!
Please don't nest the ternary operator, it is hard to read.
if (delta_ftell < 0) {
return -1;
} else if (delta_ftell > 0) {
return 1;
} else {
return 0;
}
pgpFpOncZRuo0.pgp
Description: PGP signature