[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 07/15] android-console: Init the battery ID s
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v1 07/15] android-console: Init the battery ID state field |
Date: |
Thu, 13 Nov 2014 10:05:22 +0000 |
Greg Bellows <address@hidden> writes:
> Adds initialization of the battery ID field so that it is discoverable by name
> (ID) when needed by power commands.
>
> Signed-off-by: Greg Bellows <address@hidden>
> ---
> hw/misc/goldfish_battery.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/misc/goldfish_battery.c b/hw/misc/goldfish_battery.c
> index a0bc379..11a2561 100644
> --- a/hw/misc/goldfish_battery.c
> +++ b/hw/misc/goldfish_battery.c
> @@ -141,6 +141,11 @@ static void goldfish_battery_realize(DeviceState *dev,
> Error **errp)
> SysBusDevice *sbdev = SYS_BUS_DEVICE(dev);
> struct goldfish_battery_state *s = GOLDFISH_BATTERY(dev);
>
> + /* Initialize the device ID so the battery can be looked up during
> monitor
> + * commands.
> + */
> + dev->id = strdup("goldfish_battery");
> +
We should probably use g_strdup() here.
> memory_region_init_io(&s->iomem, OBJECT(s), &goldfish_battery_iomem_ops,
> s,
> "goldfish_battery", 0x1000);
> sysbus_init_mmio(sbdev, &s->iomem);
--
Alex Bennée
- Re: [Qemu-devel] [PATCH v1 01/15] android-console: Fix goldfish audio misnaming, (continued)
- [Qemu-devel] [PATCH v1 02/15] android-console: Unify available commands output, Greg Bellows, 2014/11/11
- [Qemu-devel] [PATCH v1 03/15] android-console: Remove extra redir help message, Greg Bellows, 2014/11/11
- [Qemu-devel] [PATCH v1 04/15] android-console: Consolidate redir help text, Greg Bellows, 2014/11/11
- [Qemu-devel] [PATCH v1 05/15] android-console: Add console base power command, Greg Bellows, 2014/11/11
- [Qemu-devel] [PATCH v1 09/15] android-console: Add GF battery prop print func, Greg Bellows, 2014/11/11
- [Qemu-devel] [PATCH v1 06/15] android-console: Add missing hw_has_battery prop, Greg Bellows, 2014/11/11
- [Qemu-devel] [PATCH v1 08/15] android-console: Add header for battery externs, Greg Bellows, 2014/11/11
- [Qemu-devel] [PATCH v1 07/15] android-console: Init the battery ID state field, Greg Bellows, 2014/11/11
- Re: [Qemu-devel] [PATCH v1 07/15] android-console: Init the battery ID state field,
Alex Bennée <=
- [Qemu-devel] [PATCH v1 10/15] android-console: Add GF battery property getter, Greg Bellows, 2014/11/11
- [Qemu-devel] [PATCH v1 12/15] android-console: Add power status command, Greg Bellows, 2014/11/11
- [Qemu-devel] [PATCH v1 11/15] android-console: Add power ac command, Greg Bellows, 2014/11/11
- [Qemu-devel] [PATCH v1 13/15] android-console: Add power present command, Greg Bellows, 2014/11/11
- [Qemu-devel] [PATCH v1 14/15] android-console: Add power health command, Greg Bellows, 2014/11/11
- [Qemu-devel] [PATCH v1 15/15] android-console: Add power capacity command, Greg Bellows, 2014/11/11
- Re: [Qemu-devel] [PATCH v1 00/15] android-console: Add console power command, Greg Bellows, 2014/11/12