Re: [Qemu-devel] [PATCH v2 1/9] qemu-io: Allow explicitly specifying format

[Max Reitz]

On 2014-11-10 at 15:07, Max Reitz wrote:
> On 2014-11-07 at 20:39, Kevin Wolf wrote:
> > This adds a -f option to qemu-io which allows to explicitly specify the
> > block driver to use for the given image.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> >   qemu-io.c | 28 ++++++++++++++++++++--------
> >   1 file changed, 20 insertions(+), 8 deletions(-)
>
> I would have liked the same option for the "open" command, but well.

Reviewing patch 2, yes, I totally forgot about -o driver=foo. Very well 
then.

Max

> And maybe also an error if a format but no filename has been 
> specified, but qemu-io already does not emit an error if some other 
> image option has been specified, so it's fine.
>
> Reviewed-by: Max Reitz <address@hidden>