Re: [Qemu-devel] [PATCH] block: Fix comment for bdrv_co_get_block_status

[Max Reitz]

On 2014-11-10 at 10:10, Fam Zheng wrote:
> It returns more information than binary, fix the comment.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>   block.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/block.c b/block.c
> index dacd881..42c914e 100644
> --- a/block.c
> +++ b/block.c
> @@ -3903,9 +3903,9 @@ typedef struct BdrvCoGetBlockStatusData {
>   } BdrvCoGetBlockStatusData;
>   
>   /*
> - * Returns true iff the specified sector is present in the disk image. Drivers
> - * not implementing the functionality are assumed to not support backing files,
> - * hence all their sectors are reported as allocated.
> + * Returns the status of the specified sectors. Drivers not implementing the
> + * functionality are assumed to not support backing files, hence all their
> + * sectors are reported as allocated.
>    *
>    * If 'sector_num' is beyond the end of the disk image the return value is 0
>    * and 'pnum' is set to 0.

"status" is a bit broad, but pointing to "line 86 in 
include/block/block.h" for a further explanation will probably not be 
very stable.

Reviewed-by: Max Reitz <address@hidden>