[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno i
From: |
SeokYeon Hwang |
Subject: |
[Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong |
Date: |
Mon, 10 Nov 2014 14:54:49 +0900 |
Added 'assert(os_errno > 0)' in 'error_set_errno()'.
Fixed errno since it passes wrong value to 'error_set_errno()'.
Signed-off-by: SeokYeon Hwang <address@hidden>
---
hw/pci/pcie.c | 2 +-
util/error.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 58455bd..2902f7d 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice
*hotplug_dev,
/* the slot is electromechanically locked.
* This error is propagated up to qdev and then to HMP/QMP.
*/
- error_setg_errno(errp, -EBUSY, "slot is electromechanically locked");
+ error_setg_errno(errp, EBUSY, "slot is electromechanically locked");
}
}
diff --git a/util/error.c b/util/error.c
index 2ace0d8..6c9d995 100644
--- a/util/error.c
+++ b/util/error.c
@@ -62,6 +62,7 @@ void error_set_errno(Error **errp, int os_errno, ErrorClass
err_class,
return;
}
assert(*errp == NULL);
+ assert(os_errno >= 0);
err = g_malloc0(sizeof(*err));
--
2.1.0