Re: [Qemu-devel] [RFC PATCH v4 10/25] i386: do not cross the pages boundaries in replay mode

[Andreas Färber]

Am 07.11.2014 um 11:32 schrieb Pavel Dovgalyuk:
> This patch denies crossing the boundary of the pages in the replay mode,
> because it can cause an exception. Do it only when boundary is
> crossed by the first instruction in the block.
> If current instruction already crossed the bound - it's ok,
> because an exception hasn't stopped this code.
> 
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
>  target-i386/cpu.h       |    7 +++++++
>  target-i386/translate.c |   14 ++++++++++++++
>  2 files changed, 21 insertions(+), 0 deletions(-)
> 
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 2968749..bc3f9f5 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -28,6 +28,13 @@
>  #define TARGET_LONG_BITS 32
>  #endif
>  
> +/* Maximum instruction code size */
> +#ifdef TARGET_X86_64
> +#define TARGET_MAX_INSN_SIZE 16
> +#else
> +#define TARGET_MAX_INSN_SIZE 16
> +#endif

Is this a spot-the-difference game? ;)
Seriously, if they're the same values, just drop the #ifdef.

> +
>  /* target supports implicit self modifying code */
>  #define TARGET_HAS_SMC
>  /* support for self modifying code even if the modified instruction is
[snip]

Regards,
Andreas

-- 
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg