Re: [Qemu-devel] [PATCH v2] block/vdi: Limit maximum size even futher

[Stefan Hajnoczi]

On Tue, Oct 28, 2014 at 11:12:32AM +0100, Max Reitz wrote:
> The block layer read and write functions do not like requests which are
> bigger than INT_MAX bytes. Since the VDI bmap is read and written in a
> single operation, its size is therefore limited accordingly. This
> reduces the maximum VDI image size supported by QEMU to half of what it
> currently is (down to approximately 512 TB).
> 
> The VDI test 084 has to be adapted accordingly. Actually, one could
> clearly see that it was broken from the "Could not open
> 'TEST_DIR/t.IMGFMT': Invalid argument" line for an image which was
> supposed to work just fine.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
> v2:
> - Reducing the size to just under 512 TB wasn't enough because the bmap
>   size is rounded up on sector boundaries; fixed (thanks for testing,
>   Peter)
> - Finally a patch regarding this problem that I tested myself :-)
> ---
>  block/vdi.c                | 14 ++++++++++++--
>  tests/qemu-iotests/084     | 14 +++++++-------
>  tests/qemu-iotests/084.out | 13 ++++++++-----
>  3 files changed, 27 insertions(+), 14 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgpGGpRemXmxo.pgp
Description: PGP signature