Re: [Qemu-devel] [PATCH v6 01/10] qapi: Add optional field "name" to block dirty bitmap

[Max Reitz]

On 2014-10-30 at 04:22, Fam Zheng wrote:
> This field will be set for user created dirty bitmap. Also pass in an
> error pointer to bdrv_create_dirty_bitmap, so when a name is already
> taken on this BDS, it can report an error message. This is not global
> check, two BDSes can have dirty bitmap with a common name.
>
> Implemented bdrv_find_dirty_bitmap to find a dirty bitmap by name, will
> be used later when other QMP commands want to reference dirty bitmap by
> name.
>
> Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>   block-migration.c     |  2 +-
>   block.c               | 34 +++++++++++++++++++++++++++++++++-
>   block/mirror.c        |  2 +-
>   include/block/block.h |  7 ++++++-
>   qapi/block-core.json  |  4 +++-
>   5 files changed, 44 insertions(+), 5 deletions(-)

[snip]

> diff --git a/block.c b/block.c
> index 88f6d9b..dafde4b 100644
> --- a/block.c
> +++ b/block.c
> @@ -5307,6 +5337,8 @@ BlockDirtyInfoList 
> *bdrv_query_dirty_bitmaps(BlockDriverState *bs)
>           info->count = bdrv_get_dirty_count(bs, bm);
>           info->granularity =
>               ((int64_t) BDRV_SECTOR_SIZE << hbitmap_granularity(bm->bitmap));
> +        info->has_name = !!bm->name;

Simply info->has_name = bm->name would have sufficed but it's probably 
clearer this way.

Reviewed-by: Max Reitz <address@hidden>