[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 03/12] qcow2: Create metadata list
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH 03/12] qcow2: Create metadata list |
Date: |
Mon, 3 Nov 2014 18:04:22 +0100 |
Create and destroy the metadata list on creation and destruction of a
qcow2 BDS, respectively. Skip creation if no overlap checks should be
performed.
Signed-off-by: Max Reitz <address@hidden>
---
block/qcow2.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index ed88d69..f80f9ed 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -744,6 +744,13 @@ static int qcow2_open(BlockDriverState *bs, QDict
*options, int flags,
overlap_check_template & (1 << i)) << i;
}
+ if (s->overlap_check) {
+ ret = qcow2_create_empty_metadata_list(bs, 65536, errp);
+ if (ret < 0) {
+ goto fail;
+ }
+ }
+
s->l2_bits = s->cluster_bits - 3; /* L2 is always one cluster */
s->l2_size = 1 << s->l2_bits;
/* 2^(s->refcount_order - 3) is the refcount width in bytes */
@@ -1006,6 +1013,7 @@ static int qcow2_open(BlockDriverState *bs, QDict
*options, int flags,
}
g_free(s->cluster_cache);
qemu_vfree(s->cluster_data);
+ qcow2_metadata_list_destroy(bs);
return ret;
}
@@ -1444,6 +1452,8 @@ static void qcow2_close(BlockDriverState *bs)
qemu_vfree(s->cluster_data);
qcow2_refcount_close(bs);
qcow2_free_snapshots(bs);
+
+ qcow2_metadata_list_destroy(bs);
}
static void qcow2_invalidate_cache(BlockDriverState *bs, Error **errp)
--
1.9.3
- [Qemu-devel] [PATCH 00/12] qcow2: Add new overlap check functions, Max Reitz, 2014/11/03
- [Qemu-devel] [PATCH 03/12] qcow2: Create metadata list,
Max Reitz <=
- [Qemu-devel] [PATCH 01/12] qcow2: Add new overlap check functions, Max Reitz, 2014/11/03
- [Qemu-devel] [PATCH 04/12] qcow2/overlaps: Protect image header, Max Reitz, 2014/11/03
- [Qemu-devel] [PATCH 05/12] qcow2/overlaps: Protect refcount table, Max Reitz, 2014/11/03
- [Qemu-devel] [PATCH 08/12] qcow2/overlaps: Protect active L2 tables, Max Reitz, 2014/11/03
- [Qemu-devel] [PATCH 07/12] qcow2/overlaps: Protect active L1 table, Max Reitz, 2014/11/03
- [Qemu-devel] [PATCH 06/12] qcow2/overlaps: Protect refcount blocks, Max Reitz, 2014/11/03
- [Qemu-devel] [PATCH 09/12] qcow2/overlaps: Protect snapshot table, Max Reitz, 2014/11/03
- [Qemu-devel] [PATCH 10/12] qcow2/overlaps: Protect inactive L1 tables, Max Reitz, 2014/11/03
- [Qemu-devel] [PATCH 12/12] qcow2: Use new metadata overlap check function, Max Reitz, 2014/11/03
- [Qemu-devel] [PATCH 11/12] qcow2/overlaps: Protect inactive L2 tables, Max Reitz, 2014/11/03