[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 46/53] blockdev: add note that block_job_cb() must be
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 46/53] blockdev: add note that block_job_cb() must be thread-safe |
Date: |
Mon, 3 Nov 2014 11:50:49 +0000 |
This function is correct but we should document the constraint that
everything must be thread-safe.
Emitting QMP events and scheduling BHs are both thread-safe so nothing
needs to be done here.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Message-id: address@hidden
---
blockdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 741df98..774051b 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1929,6 +1929,11 @@ out:
static void block_job_cb(void *opaque, int ret)
{
+ /* Note that this function may be executed from another AioContext besides
+ * the QEMU main loop. If you need to access anything that assumes the
+ * QEMU global mutex, use a BH or introduce a mutex.
+ */
+
BlockDriverState *bs = opaque;
const char *msg = NULL;
--
1.9.3
- [Qemu-devel] [PULL 35/53] block: qemu-iotest 107 supports NFS, (continued)
- [Qemu-devel] [PULL 35/53] block: qemu-iotest 107 supports NFS, Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 37/53] qemu-img: Add progress output for amend, Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 38/53] qemu-img: Fix insignificant memleak, Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 39/53] block/qcow2: Implement status CB for amend, Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 40/53] block/qcow2: Make get_refcount() global, Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 41/53] block/qcow2: Simplify shared L2 handling in amend, Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 42/53] iotests: Expand test 061, Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 43/53] block: acquire AioContext in generic blockjob QMP commands, Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 44/53] blockdev: acquire AioContext in do_qmp_query_block_jobs_one(), Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 45/53] blockdev: acquire AioContext in blockdev_mark_auto_del(), Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 46/53] blockdev: add note that block_job_cb() must be thread-safe,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 47/53] blockjob: add block_job_defer_to_main_loop(), Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 48/53] block: add bdrv_drain(), Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 49/53] block: let backup blockjob run in BDS AioContext, Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 50/53] block: let stream blockjob run in BDS AioContext, Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 52/53] block: let commit blockjob run in BDS AioContext, Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 53/53] block: declare blockjobs and dataplane friends!, Stefan Hajnoczi, 2014/11/03
- [Qemu-devel] [PULL 51/53] block: let mirror blockjob run in BDS AioContext, Stefan Hajnoczi, 2014/11/03
- Re: [Qemu-devel] [PULL 00/53] Block patches, Peter Maydell, 2014/11/03