Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

[Peter Maydell]

On 30 October 2014 12:37, Dr. David Alan Gilbert <address@hidden> wrote:
> * Amit Shah (address@hidden) wrote:
>> On (Thu) 16 Oct 2014 [08:53:52], Dr. David Alan Gilbert (git) wrote:
>>
>> >  rename migration-exec.c => migration/migration-exec.c (100%)
>> >  rename migration-fd.c => migration/migration-fd.c (100%)
>> >  rename migration-rdma.c => migration/migration-rdma.c (100%)
>> >  rename migration-tcp.c => migration/migration-tcp.c (100%)
>> >  rename migration-unix.c => migration/migration-unix.c (100%)
>> >  rename migration.c => migration/migration.c (100%)
>>
>> I'm wondering if we should also use the opportunity to cleanup the
>> file names:
>>
>> migration.c => main.c
>> migration-X.c => X.c
>>
>> ?
>
> I'd be OK with changing filenames, but they would have to
> be fairly clear; I don't like having a 'main.c' because that's
> where I'd expect to find a main() - but we do have a few core.c's
> as the core of each of a few hw subdirs.

Yeah, I think I agree that 'main.c' is not a great choice
(but core.c or migration.c would be fine); for the others I
agree with Amit that we should drop the migration- prefix
as we move them. (It's generally how we've handled other
moves-into-subdirectories in the past; various arm_* and
alpha_* files lost their prefixes when they moved into hw/arm
and hw/alpha, for instance.)

thanks
-- PMM