[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/17] scsi: Rename scsi_cdb_length() to scsi_xf
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 03/17] scsi: Rename scsi_cdb_length() to scsi_xfer_length() |
|
Date: |
Thu, 30 Oct 2014 13:00:27 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 10/30/2014 12:26 PM, Hannes Reinecke wrote:
> > Why would req->cmd.len be wrong though? Are you masking another bug?
>
> No. I'm _fixing_ a bug.
Sure, I just wasn't sure which/how. :)
> scsi_disk.c:scsi_new_request() is just calling scsi_req_alloc(),
> which does not set cmd.len.
> Yet later on scsi_new_request() uses cmd.len to print out the CDB,
> which at the time isn't initialized.
Ah, right---req->cmd is set after scsi_new_request() returns.
Paolo
- [Qemu-devel] [PATCH 06/17] megasas: fixup MFI_DCMD_LD_LIST_QUERY, (continued)
- [Qemu-devel] [PATCH 06/17] megasas: fixup MFI_DCMD_LD_LIST_QUERY, Hannes Reinecke, 2014/10/29
- [Qemu-devel] [PATCH 16/17] megasas: Rework frame queueing algorithm, Hannes Reinecke, 2014/10/29
- [Qemu-devel] [PATCH 09/17] megasas: add MegaRAID SAS 2108 emulation, Hannes Reinecke, 2014/10/29
- [Qemu-devel] [PATCH 12/17] megasas: Clear unit attention on initial reset, Hannes Reinecke, 2014/10/29
- [Qemu-devel] [PATCH 03/17] scsi: Rename scsi_cdb_length() to scsi_xfer_length(), Hannes Reinecke, 2014/10/29
- [Qemu-devel] [PATCH 10/17] megasas: Fix typo in megasas_dcmd_ld_get_list(), Hannes Reinecke, 2014/10/29
- [Qemu-devel] [PATCH 07/17] megasas: simplify trace event messages, Hannes Reinecke, 2014/10/29
- [Qemu-devel] [PATCH 11/17] megasas: Decode register names, Hannes Reinecke, 2014/10/29
- [Qemu-devel] [PATCH 14/17] megasas: Implement DCMD_CLUSTER_RESET_LD, Hannes Reinecke, 2014/10/29
- [Qemu-devel] [PATCH 13/17] megasas: Ignore duplicate init_firmware commands, Hannes Reinecke, 2014/10/29
- [Qemu-devel] [PATCH 15/17] megasas: Update queue logging, Hannes Reinecke, 2014/10/29
- [Qemu-devel] [PATCH 17/17] megasas: Fixup MSI-X handling, Hannes Reinecke, 2014/10/29
- [Qemu-devel] [PATCH 02/17] atapi: clear sense code, Hannes Reinecke, 2014/10/29
- Re: [Qemu-devel] [PATCH 00/17] megasas: gen2 emulation and MSI-X fixes, Paolo Bonzini, 2014/10/29