[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/6] target-i386: Don't enable nested VMX by
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/6] target-i386: Don't enable nested VMX by default |
Date: |
Thu, 30 Oct 2014 08:17:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
> Here I'm less certain what the best approach is. As you point out,
> there's an inconsistency that I agree should be fixed. I wonder however
> whether an approach similar to 3/6 for KVM only would be better? I.e.,
> have VMX as a sometimes-KVM-supported feature be listed in the model and
> filter it out for accel=kvm so that -cpu enforce works, but let
> accel=tcg fail with features not implemented.
This would mean that -cpu coreduo,enforce doesn't work on TCG, but -cpu
Nehalem,enforce works. This does not make much sense to me.
In fact, I would even omit the x86_cpu_compat_set_features altogether.
The inclusion of vmx in these models was a mistake, and nested VMX is
not really useful with anything but "-cpu host" because there are too
many capabilities communicated via MSRs rather than CPUID.
Paolo
- [Qemu-devel] [PATCH v3 0/6] target-i386: Make most CPU models work with "enforce" out of the box, Eduardo Habkost, 2014/10/03
- [Qemu-devel] [PATCH v3 4/6] target-i386: Remove unsupported bits from all CPU models, Eduardo Habkost, 2014/10/03
- [Qemu-devel] [PATCH v3 1/6] pc: Create pc_compat_2_1() functions, Eduardo Habkost, 2014/10/03
- [Qemu-devel] [PATCH v3 2/6] target-i386: Rename KVM auto-feature-enable compat function, Eduardo Habkost, 2014/10/03
- [Qemu-devel] [PATCH v3 3/6] target-i386: Disable CPUID_ACPI by default on KVM mode, Eduardo Habkost, 2014/10/03
- [Qemu-devel] [PATCH v3 5/6] target-i386: Don't enable nested VMX by default, Eduardo Habkost, 2014/10/03
- [Qemu-devel] [PATCH v3 6/6] target-i386: Disable SVM by default in KVM mode, Eduardo Habkost, 2014/10/03
- Re: [Qemu-devel] [PATCH v3 0/6] target-i386: Make most CPU models work with "enforce" out of the box, Paolo Bonzini, 2014/10/03