[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] snapshot: Reset err to NULL to avoid double fre
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] snapshot: Reset err to NULL to avoid double free |
|
Date: |
Tue, 28 Oct 2014 14:31:30 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Oct 06, 2014 at 09:33:45AM -0700, Chris Spiegel wrote:
> If an error occurs in bdrv_snapshot_delete_by_id_or_name(), "err" is
> freed. If "err" is not set to NULL before calling
> bdrv_snapshot_delete_by_id_or_name() again, it will not be updated on
> error, and will be freed again.
>
> This can be triggered by starting a VM with at least two drives and then
> attempting to delete a non-existent snapshot.
>
> Signed-off-by: Chris Spiegel <address@hidden>
> ---
> savevm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgpy5qbmMKj4T.pgp
Description: PGP signature