Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory

[zhanghailiang]

On 2014/10/27 20:46, Luiz Capitulino wrote:
> On Mon, 27 Oct 2014 17:40:11 +0800
> zhanghailiang <address@hidden> wrote:
>
> > Hi Luiz,
> >
> > Can you apply this to your qmp branch?
> > It has been reviewd;)
>
> I can, but I don't have bandwidth for another pull request for v2.2 unless
> it's a fix for a blocker. This means you have two options, wait for v2.3
> or find another tree to merge this.

OK, i will wait for v2.3, thanks;)

> > Thanks,
> > zhanghailiang
> >
> > On 2014/10/23 8:32, zhanghailiang wrote:
> > > Hi,
> > >
> > > Ping...
> > > This patch has been reviewed, please pick up, Thanks.
> > >
> > > Best Regargs,
> > > zhanghailiang
> > >
> > > On 2014/10/17 17:02, Gonglei wrote:
> > > > On 2014/10/17 16:50, zhanghailiang wrote:
> > > >
> > > > > When do memory hotplug, if there is numa node, we should add
> > > > > the memory size to the corresponding node memory size.
> > > > >
> > > > > For now, it mainly affects the result of hmp command "info numa".
> > > > >
> > > > > Reviewed-by: Igor Mammedov <address@hidden>
> > > > > Signed-off-by: zhanghailiang <address@hidden>
> > > > > ---
> > > > >    v6:
> > > > > - remove unnecessary 'di' variable (GongLei)
> > > > >    v5:
> > > > > - reword the subject (Igor Mammedov)
> > > > > - turn query_numa_node_mem to void (Igor Mammedov)
> > > > >    v4:
> > > > > - s/pc_dimm_stat_node_mem/numa_stat_memory_devices/ (Igor Mammedov)
> > > > > - rewrite numa_stat_memory_devices and this will also fix compile error for
> > > > >     targets that don't support memory hotplug
> > > > >    v3:
> > > > > - cold-plugged memory should not be excluded (Igor Mammedov)
> > > > >    v2:
> > > > > - Don't modify the numa_info.node_mem directly when treating hotplug memory,
> > > > >     fix the "info numa" instead (Igor Mammedov)
> > > > >
> > > > > Thanks for review!;)
> > > > > ---
> > > > >
> > > > >    include/sysemu/sysemu.h |  1 +
> > > > >    monitor.c               |  6 +++++-
> > > > >    numa.c                  | 38 ++++++++++++++++++++++++++++++++++++++
> > > > >    3 files changed, 44 insertions(+), 1 deletion(-)
> > > >
> > > > Reviewed-by: Gonglei <address@hidden>
> > > >
> > > > Best regards,
> > > > -Gonglei
> > > >
> > > >
> > > > .
>
>
> .