[Qemu-devel] [PATCH 0/2] block: Propagate error in bdrv_img_create()

[Max Reitz]

Currently, when trying to create a backed image without specifying its
size, when the backing file does not exist or is not accessible, an
appropriate error message will be generated which is then (in
bdrv_img_create()) prefixed with the image file name and the strerror().
However, both are generally already part of the bdrv_open() error
message, so we should not double this information. An example:

$ qemu-img create -f qcow2 -b /tmp/enoent /tmp/img.qcow2
qemu-img: /tmp/img.qcow2: Could not open '/tmp/enoent': Could not open
'/tmp/enoent': No such file or directory: No such file or directory

Just propagating the error is sufficient:

$ qemu-img create -f qcow2 -b /tmp/enoent /tmp/img.qcow2
qemu-img /tmp/img.qcow2: Could not open '/tmp/enoent': No such file or
directory


Max Reitz (2):
  block: Propagate error in bdrv_img_create()
  iotests: Add test for non-existing backing file

 block.c                    |  5 -----
 tests/qemu-iotests/111     | 53 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/111.out |  3 +++
 tests/qemu-iotests/group   |  1 +
 4 files changed, 57 insertions(+), 5 deletions(-)
 create mode 100755 tests/qemu-iotests/111
 create mode 100644 tests/qemu-iotests/111.out

-- 
1.9.3