qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qemu-img: Print error if check failed


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH] qemu-img: Print error if check failed
Date: Thu, 23 Oct 2014 17:01:05 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

On 2014-10-23 at 15:29, Max Reitz wrote:
Currently, if bdrv_check() fails either by returning -errno or having
check_errors set, qemu-img check just exits with 1 after having told the
user that there were no errors on the image. This is bad.

Instead of printing the check result if there were internal errors which
were so bad that bdrv_check() could not even complete with 0 as a return
value, qemu-img check should inform the user about the error.

Signed-off-by: Max Reitz <address@hidden>
---
  qemu-img.c | 21 ++++++++++++++-------
  1 file changed, 14 insertions(+), 7 deletions(-)

This feels greedy, but Kevin encouraged me to on IRC, so:

Applied to my block tree:
https://github.com/XanClic/qemu/commits/block

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]