[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 11/14] qemu-img: Specify backing file for co
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v13 11/14] qemu-img: Specify backing file for commit |
Date: |
Thu, 23 Oct 2014 15:05:22 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> Introduce a new parameter for qemu-img commit which may be used to
> explicitly specify the backing file into which an image should be
> committed if the backing chain has more than a single layer.
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
> +If the backing chain of the given image file @var{filename} has more than one
> +layer, the backing file into which the changes will be committed may be
> +specified as @var{base} (which has to be part of @var{filename}'s backing
> +chain). If @var{base} is not specified, the immediate backing file of the top
> +image (which is @var{filename}) will be used. For reasons of consistency,
> +explicitly specifying @var{base} will always imply @code{-d}.
Wouldn't hurt, though, to be more explicit about the "reasons of
consistency". Took me a few moments to understand.
Kevin
- Re: [Qemu-devel] [PATCH v13 08/14] qemu-img: Implement commit like QMP, (continued)
[Qemu-devel] [PATCH v13 09/14] qemu-img: Empty image after commit, Max Reitz, 2014/10/22
[Qemu-devel] [PATCH v13 10/14] qemu-img: Enable progress output for commit, Max Reitz, 2014/10/22
[Qemu-devel] [PATCH v13 11/14] qemu-img: Specify backing file for commit, Max Reitz, 2014/10/22
- Re: [Qemu-devel] [PATCH v13 11/14] qemu-img: Specify backing file for commit,
Kevin Wolf <=
[Qemu-devel] [PATCH v13 12/14] iotests: Add _filter_qemu_img_map, Max Reitz, 2014/10/22
[Qemu-devel] [PATCH v13 13/14] iotests: Add test for backing-chain commits, Max Reitz, 2014/10/22
[Qemu-devel] [PATCH v13 14/14] iotests: Add test for qcow2's bdrv_make_empty, Max Reitz, 2014/10/22