Re: [Qemu-devel] [PATCH 3/5] vmware-vga: use vmsvga_verify_rect in vmsvga_update_rect

[Gerd Hoffmann]

On Di, 2014-10-14 at 11:29 +0200, BALATON Zoltan wrote:
> On Tue, 14 Oct 2014, Gerd Hoffmann wrote:
> > Switch vmsvga_update_rect over to use vmsvga_verify_rect.  Slight change
> > in behavior:  We don't try to automatically fixup rectangles any more.
> > Invalid update requests will be ignored instead.
> 
> Are you sure this won't break clients? I remember that maybe Windows 
> drivers did produce requests with partially off screen rectangles for 
> objects that are partially visible. I don't recall if this was for windows 
> dragged off screen or mouse pointer near the screen but there was a reason 
> this fixup was added. Did you test this?

Not tested.  I don't have windows guests with vmware drivers.  The
fixups avoid qemu crashing for sure.  Possibly they are also needed to
prevent rendering problems.  Should that be the case I'd tend to simply
do a full-screen refresh as fallback should we see invalid rectangles
instead of keeping the fixup logic.  The fixups become quite complex for
the bitblit case, thats why I dropped them.

cheers,
  Gerd