|
From: | Max Reitz |
Subject: | Re: [Qemu-devel] [PATCH v5 08/11] qcow2: Rebuild refcount structure during check |
Date: | Sun, 12 Oct 2014 09:32:40 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
Am 11.10.2014 um 20:56 schrieb Benoît Canet:
+ int64_t first_free_cluster = 0, rt_ofs = -1, cluster = 0; + int64_t rb_ofs, rb_start, rb_index;Everytime a few day pass and I read rb_ofs and rt_ofs again I found these names obfuscated. I know Linus says that C is a spartan language but these look odd. Maybe refcount_block_offset, refcount_block_* and refcount_table_offset would be better.
I would use longer names if there was no line length limit. ;-) I'll try and see how it looks. Max
[Prev in Thread] | Current Thread | [Next in Thread] |