Re: [Qemu-devel] [PATCH v2 1/2] libqos: improve event_index test with timeout

[Peter Maydell]

On 29 September 2014 16:40, Stefan Hajnoczi <address@hidden> wrote:
> The virtio event_index feature lets the device driver tell the device
> how many requests to process before raising the next interrupt.
> virtio-blk-test.c tries to verify that the device does not raise an
> interrupt unnecessarily.
>
> Unfortunately the test has a race condition.  It spins checking for an
> interrupt up to 100 times and then assumes the request has finished.  On
> a slow host the I/O request could still be in flight and the test would
> fail.
>
> This patch waits for the request to complete, or until a 30-second
> timeout is reached.  If an interrupt is raised while waiting the test
> fails since the device was not supposed to raise interrupts.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>

Hi; just noticed this breaks 'make check' build on MacOSX:

/Users/pm215/src/qemu/tests/libqos/virtio.c:84:25: warning: implicit
declaration of function
      'g_get_monotonic_time' is invalid in C99 [-Wimplicit-function-declaration]
    gint64 start_time = g_get_monotonic_time();
                        ^
(and subsequent linker error).

g_get_monotonic_time() only appeared in glib 2.28, and our
minimum is 2.12.

thanks
-- PMM