Re: [Qemu-devel] [PULL 0/8] s390x patches for 2.2

[Cornelia Huck]

On Thu, 9 Oct 2014 18:23:07 +0100
Peter Maydell <address@hidden> wrote:

> On 9 October 2014 18:18, Cornelia Huck <address@hidden> wrote:
> >
> > Weird, s390x-linux-user seems to build for me on s390x (just tried
> > again).
> >
> > I guess you build on !s390x, though :) I'll look into this.
> 
> You seem to be building the migration stuff into the linux-user
> targets, when it should be in softmmu only. Other targets
> handle this by putting it into machine.c and marking
> that file SOFTMMU only. I'm not sure why it compiles for
> you on s390x, I don't think it's a host-system specific
> problem...

Yep. I just built on i386 again and it builds for me as well. May have
some magic fairy dust on my disks ;)

But I agree, let's just introduce machine.c and move the code there.