[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 17/34] net: remove bootindex property from q
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [PATCH v11 17/34] net: remove bootindex property from qdev to qom |
Date: |
Thu, 9 Oct 2014 19:56:03 +0800 |
> Subject: Re: [Qemu-devel] [PATCH v11 17/34] net: remove bootindex property
> from qdev to qom
>
> Il 07/10/2014 10:00, address@hidden ha scritto:
> > From: Gonglei <address@hidden>
> >
> > Remove bootindex form qdev property to qom, things will
> > continue to work just fine, and we can use qom features
> > which are not supported by qdev property.
> >
> > Signed-off-by: Gonglei <address@hidden>
> > Reviewed-by: Gerd Hoffmann <address@hidden>
> > ---
> > include/net/net.h | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/include/net/net.h b/include/net/net.h
> > index ed594f9..008d610 100644
> > --- a/include/net/net.h
> > +++ b/include/net/net.h
> > @@ -36,8 +36,7 @@ typedef struct NICConf {
> > #define DEFINE_NIC_PROPERTIES(_state, _conf)
> \
> > DEFINE_PROP_MACADDR("mac", _state, _conf.macaddr),
> \
> > DEFINE_PROP_VLAN("vlan", _state, _conf.peers),
> \
> > - DEFINE_PROP_NETDEV("netdev", _state, _conf.peers),
> \
> > - DEFINE_PROP_INT32("bootindex", _state, _conf.bootindex, -1)
> > + DEFINE_PROP_NETDEV("netdev", _state, _conf.peers)
> >
> >
> > /* Net clients */
> >
>
> This is a bit of a pity, and it's caused by the different nature of QOM
> properties (instance-based) vs. qdev properties (class-based).
>
> I can live with that.
>
> Paolo
Hmm... Thanks :)
Best regards,
-Gonglei
- [Qemu-devel] [PATCH v11 30/34] nvma: ide: add bootindex to qom property, (continued)
- [Qemu-devel] [PATCH v11 30/34] nvma: ide: add bootindex to qom property, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 22/34] redirect: remove bootindex property from qdev to qom, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 21/34] vfio: remove bootindex property from qdev to qom, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 26/34] virtio-blk: add bootindex to qom property, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 33/34] bootindex: delete bootindex when device is removed, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 05/34] bootindex: rework add_boot_device_path function, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 04/34] fw_cfg: add fw_cfg_machine_reset function, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 17/34] net: remove bootindex property from qdev to qom, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 28/34] virtio-blk: alias bootindex property explicitly for virt-blk-pci/ccw/s390, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 34/34] bootindex: change fprintf to error_report, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 23/34] isa-fdc: remove bootindexA/B property from qdev to qom, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 25/34] ide: add bootindex to qom property, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 29/34] usb-storage: add bootindex to qom property, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 32/34] bootindex: move calling add_boot_device_patch to bootindex setter function, arei.gonglei, 2014/10/07
- [Qemu-devel] [PATCH v11 27/34] block: remove bootindex property from qdev to qom, arei.gonglei, 2014/10/07
- Re: [Qemu-devel] [PATCH v11 00/34] modify boot order of guest, and take effect after rebooting, Gonglei, 2014/10/08