[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error repor
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting |
Date: |
Wed, 08 Oct 2014 08:56:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
address@hidden writes:
> From: Corey Minyard <address@hidden>
>
> If reconnect was set, errors wouldn't always be reported.
> Fix that and also only report a connect error once until a
> connection has been made.
>
> The primary purpose of this is to tell the user that a
> connection failed so they can know they need to figure out
> what went wrong. So we don't want to spew too much
> out here, just enough so they know.
>
> Signed-off-by: Corey Minyard <address@hidden>
> ---
> qemu-char.c | 47 ++++++++++++++++++++++++++++++++---------------
> 1 file changed, 32 insertions(+), 15 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 62af0ef..fb895c7 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2509,6 +2509,7 @@ typedef struct {
>
> guint reconnect_timer;
> int64_t reconnect_time;
> + bool connect_err_reported;
> } TCPCharDriver;
>
> static gboolean socket_reconnect_timeout(gpointer opaque);
Doesn't apply, obviously depends on some other patch. Always state your
dependencies explicitly in the cover letter!
[...]