qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 6/8] throttle: Add a way to fire one of the t


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v1 6/8] throttle: Add a way to fire one of the timers asap like a bottom half
Date: Wed, 8 Oct 2014 14:26:02 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, 10/07 15:24, Benoît Canet wrote:
> This will be needed by the group throttling algorithm.
> 
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  include/qemu/throttle.h |  2 ++
>  util/throttle.c         | 11 +++++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h
> index 3a16c48..3b9d1b8 100644
> --- a/include/qemu/throttle.h
> +++ b/include/qemu/throttle.h
> @@ -127,6 +127,8 @@ bool throttle_schedule_timer(ThrottleState *ts,
>                               bool is_write,
>                               bool *armed);
>  
> +void throttle_fire_timer(ThrottleTimers *tt, bool is_write);
> +
>  void throttle_timer_fired(ThrottleState *ts, bool is_write);
>  
>  void throttle_account(ThrottleState *ts, bool is_write, uint64_t size);
> diff --git a/util/throttle.c b/util/throttle.c
> index a273acb..163b9d0 100644
> --- a/util/throttle.c
> +++ b/util/throttle.c
> @@ -403,6 +403,17 @@ bool throttle_schedule_timer(ThrottleState *ts,
>      return true;
>  }
>  
> +/* Schedule a throttle timer like a BH

Why not use a real BH? It's more efficient than a timer scheduled at now + 1.

Fam

> + *
> + * @tt:       The timers structure
> + * @is_write: the type of operation (read/write)
> + */
> +void throttle_fire_timer(ThrottleTimers *tt, bool is_write)
> +{
> +    int64_t now = qemu_clock_get_ns(tt->clock_type);
> +    timer_mod(tt->timers[is_write], now + 1);
> +}
> +
>  /* Remember that now timers are currently armed
>   *
>   * @ts:       the throttle state we are working on
> -- 
> 2.1.1
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]