[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RFC 04/11] s390x/virtio-ccw: fix check for WRITE_FEA
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PATCH RFC 04/11] s390x/virtio-ccw: fix check for WRITE_FEAT |
Date: |
Tue, 7 Oct 2014 16:40:00 +0200 |
We need to check guest feature size, not host feature size to find
out whether we should call virtio_set_features(). This check is
possible now that vdev->guest_features is an array.
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
hw/s390x/virtio-ccw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index 8aa79a7..69add47 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -399,7 +399,7 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
features.index = ldub_phys(&address_space_memory,
ccw.cda + sizeof(features.features));
features.features = ldl_le_phys(&address_space_memory, ccw.cda);
- if (features.index < ARRAY_SIZE(dev->host_features)) {
+ if (features.index < ARRAY_SIZE(vdev->guest_features)) {
virtio_set_features(vdev, features.index, features.features);
} else {
/*
--
1.7.9.5
- [Qemu-devel] [PATCH RFC 03/11] virtio: support more feature bits, (continued)
- [Qemu-devel] [PATCH RFC 03/11] virtio: support more feature bits, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 11/11] s390x/virtio-ccw: enable virtio 1.0, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 08/11] s390x/css: Add a callback for when subchannel gets disabled, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 02/11] virtio: cull virtio_bus_set_vdev_features, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 05/11] virtio: introduce legacy virtio devices, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 06/11] virtio: allow virtio-1 queue layout, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 10/11] s390x/virtio-ccw: support virtio-1 set_vq format, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 04/11] s390x/virtio-ccw: fix check for WRITE_FEAT,
Cornelia Huck <=
- [Qemu-devel] [PATCH RFC 01/11] linux-headers/virtio_config: Update with VIRTIO_F_VERSION_1, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 07/11] dataplane: allow virtio-1 devices, Cornelia Huck, 2014/10/07
- Re: [Qemu-devel] [PATCH RFC 00/11] qemu: towards virtio-1 host support, Andy Lutomirski, 2014/10/07