[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 22/24] blockdev: Convert qmp_eject(), qmp_change_
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v6 22/24] blockdev: Convert qmp_eject(), qmp_change_blockdev() to BlockBackend |
Date: |
Tue, 7 Oct 2014 13:59:24 +0200 |
Much more command code needs conversion. I'm converting these now
because they're using bdrv_dev_* functions, which I'm about to lift
into BlockBackend.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: BenoƮt Canet <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
blockdev.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 2a3d908..a32d84c 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1593,8 +1593,10 @@ exit:
}
-static void eject_device(BlockDriverState *bs, int force, Error **errp)
+static void eject_device(BlockBackend *blk, int force, Error **errp)
{
+ BlockDriverState *bs = blk_bs(blk);
+
if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_EJECT, errp)) {
return;
}
@@ -1618,15 +1620,15 @@ static void eject_device(BlockDriverState *bs, int
force, Error **errp)
void qmp_eject(const char *device, bool has_force, bool force, Error **errp)
{
- BlockDriverState *bs;
+ BlockBackend *blk;
- bs = bdrv_find(device);
- if (!bs) {
+ blk = blk_by_name(device);
+ if (!blk) {
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
return;
}
- eject_device(bs, force, errp);
+ eject_device(blk, force, errp);
}
void qmp_block_passwd(bool has_device, const char *device,
@@ -1685,16 +1687,18 @@ static void qmp_bdrv_open_encrypted(BlockDriverState
*bs, const char *filename,
void qmp_change_blockdev(const char *device, const char *filename,
const char *format, Error **errp)
{
+ BlockBackend *blk;
BlockDriverState *bs;
BlockDriver *drv = NULL;
int bdrv_flags;
Error *err = NULL;
- bs = bdrv_find(device);
- if (!bs) {
+ blk = blk_by_name(device);
+ if (!blk) {
error_set(errp, QERR_DEVICE_NOT_FOUND, device);
return;
}
+ bs = blk_bs(blk);
if (format) {
drv = bdrv_find_whitelisted_format(format, bs->read_only);
@@ -1704,7 +1708,7 @@ void qmp_change_blockdev(const char *device, const char
*filename,
}
}
- eject_device(bs, 0, &err);
+ eject_device(blk, 0, &err);
if (err) {
error_propagate(errp, err);
return;
--
1.9.3
- [Qemu-devel] [PATCH v6 21/24] block/qapi: Convert qmp_query_block() to BlockBackend, (continued)
- [Qemu-devel] [PATCH v6 21/24] block/qapi: Convert qmp_query_block() to BlockBackend, Markus Armbruster, 2014/10/07
- [Qemu-devel] [PATCH v6 02/24] block: New BlockBackend, Markus Armbruster, 2014/10/07
- [Qemu-devel] [PATCH v6 03/24] block: Connect BlockBackend to BlockDriverState, Markus Armbruster, 2014/10/07
- [Qemu-devel] [PATCH v6 09/24] block: Eliminate BlockDriverState member device_name[], Markus Armbruster, 2014/10/07
- [Qemu-devel] [PATCH v6 17/24] ide: Complete conversion from BlockDriverState to BlockBackend, Markus Armbruster, 2014/10/07
- [Qemu-devel] [PATCH v6 19/24] blockdev: Drop superfluous DriveInfo member id, Markus Armbruster, 2014/10/07
- [Qemu-devel] [PATCH v6 12/24] block: Rename BlockDriverAIOCB* to BlockAIOCB*, Markus Armbruster, 2014/10/07
- [Qemu-devel] [PATCH v6 15/24] virtio-blk: Rename VirtIOBlkConf variables to conf, Markus Armbruster, 2014/10/07
- [Qemu-devel] [PATCH v6 20/24] blockdev: Fix blockdev-add not to create DriveInfo, Markus Armbruster, 2014/10/07
- [Qemu-devel] [PATCH v6 22/24] blockdev: Convert qmp_eject(), qmp_change_blockdev() to BlockBackend,
Markus Armbruster <=
- [Qemu-devel] [PATCH v6 18/24] pc87312: Drop unused members of PC87312State, Markus Armbruster, 2014/10/07
- [Qemu-devel] [PATCH v6 23/24] block: Lift device model API into BlockBackend, Markus Armbruster, 2014/10/07
- [Qemu-devel] [PATCH v6 13/24] block: Rename BlockDriverCompletionFunc to BlockCompletionFunc, Markus Armbruster, 2014/10/07
- [Qemu-devel] [PATCH v6 16/24] hw: Convert from BlockDriverState to BlockBackend, mostly, Markus Armbruster, 2014/10/07
- Re: [Qemu-devel] [PATCH v6 00/24] Split BlockBackend off BDS with an axe, Kevin Wolf, 2014/10/17