[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client socke
From: |
Corey Minyard |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets |
Date: |
Fri, 03 Oct 2014 22:24:23 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 10/03/2014 05:22 PM, Paolo Bonzini wrote:
> Il 02/10/2014 18:17, address@hidden ha scritto:
>> + if (!qemu_chr_open_socket_fd(chr, &err)) {
>> + error_report("Unable to connect to char device %s\n", chr->label);
>> + qemu_chr_socket_restart_timer(chr);
>> + }
> Can you please add a follow-up patch that only prints this message once
> per reconnect? Otherwise a server that shuts down can spam logs forever.
Yes, not a problem. I always wonder the best way to handle something
like that, but you are probably right.
> I'll nevertheless queue the patches for 2.2 next week.
Thank you,
-corey
> Thanks,
>
> Paolo
- [Qemu-devel] [PATCH v5 0/6] Add reconnecting to client sockets, minyard, 2014/10/02
- [Qemu-devel] [PATCH 1/6] qemu-char: Make the filename size for a chardev a #define, minyard, 2014/10/02
- [Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected, minyard, 2014/10/02
- [Qemu-devel] [PATCH 6/6] qemu-char: Print the remote and local addresses for a socket, minyard, 2014/10/02
- [Qemu-devel] [PATCH 3/6] qemu-char: Move some items into TCPCharDriver, minyard, 2014/10/02
- [Qemu-devel] [PATCH 2/6] qemu-char: Rework qemu_chr_open_socket() for reconnect, minyard, 2014/10/02
- [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets, minyard, 2014/10/02