[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] blockdev-test: Factor out some common code
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] blockdev-test: Factor out some common code into helpers |
Date: |
Thu, 02 Oct 2014 09:35:31 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
On 10/02/2014 08:51 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/drive_del-test.c | 60
> +++++++++++++++++++++++++-------------------------
> 1 file changed, 30 insertions(+), 30 deletions(-)
>
> diff --git a/tests/drive_del-test.c b/tests/drive_del-test.c
> index 2baf0b7..463479d 100644
> --- a/tests/drive_del-test.c
> +++ b/tests/drive_del-test.c
> @@ -14,32 +14,44 @@
> #include <string.h>
> #include "libqtest.h"
>
> +static void drive_add(void)
> +{
> + QDict *response;
> +
> + response = qmp("{'execute': 'human-monitor-command',"
> + " 'arguments': {"
> + " 'command-line': 'drive_add 0 if=none,id=drive0'"
> + "}}");
I'm still not necessarily a fan of '' in QMP, but this follows existing
practice.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/6] Improve drive_del test coverage, Markus Armbruster, 2014/10/02
- [Qemu-devel] [PATCH 4/6] blockdev-test: Simplify by using g_assert_cmpstr(), Markus Armbruster, 2014/10/02
- [Qemu-devel] [PATCH 2/6] blockdev-test: Use single rather than double quotes in QMP, Markus Armbruster, 2014/10/02
- [Qemu-devel] [PATCH 5/6] blockdev-test: Factor out some common code into helpers, Markus Armbruster, 2014/10/02
- Re: [Qemu-devel] [PATCH 5/6] blockdev-test: Factor out some common code into helpers,
Eric Blake <=
- [Qemu-devel] [PATCH 6/6] blockdev-test: Test device_del after drive_del, Markus Armbruster, 2014/10/02
- [Qemu-devel] [PATCH 3/6] blockdev-test: Clean up bogus drive_add argument, Markus Armbruster, 2014/10/02
- [Qemu-devel] [PATCH 1/6] drive_del-test: Merge of qdev-monitor-test, blockdev-test, Markus Armbruster, 2014/10/02
- Re: [Qemu-devel] [PATCH 0/6] Improve drive_del test coverage, Stefan Hajnoczi, 2014/10/04