[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/11] blockdev: acquire AioContext in do_qmp_query_
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 02/11] blockdev: acquire AioContext in do_qmp_query_block_jobs_one() |
Date: |
Wed, 1 Oct 2014 18:01:50 +0100 |
Make sure that query-block-jobs acquires the BlockDriverState
AioContext so that the blockjob isn't running in another thread while we
access its state.
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
blockdev.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 379a268..270425d 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2585,14 +2585,19 @@ fail:
static void do_qmp_query_block_jobs_one(void *opaque, BlockDriverState *bs)
{
BlockJobInfoList **prev = opaque;
- BlockJob *job = bs->job;
+ AioContext *aio_context;
+
+ aio_context = bdrv_get_aio_context(bs);
+ aio_context_acquire(aio_context);
- if (job) {
+ if (bs->job) {
BlockJobInfoList *elem = g_new0(BlockJobInfoList, 1);
elem->value = block_job_query(bs->job);
(*prev)->next = elem;
*prev = elem;
}
+
+ aio_context_release(aio_context);
}
BlockJobInfoList *qmp_query_block_jobs(Error **errp)
--
1.9.3
- [Qemu-devel] [PATCH 00/11] block: allow blockjobs to coexist with dataplane, Stefan Hajnoczi, 2014/10/01
- [Qemu-devel] [PATCH 01/11] block: acquire AioContext in generic blockjob QMP commands, Stefan Hajnoczi, 2014/10/01
- [Qemu-devel] [PATCH 03/11] blockdev: acquire AioContext in blockdev_mark_auto_del(), Stefan Hajnoczi, 2014/10/01
- [Qemu-devel] [PATCH 02/11] blockdev: acquire AioContext in do_qmp_query_block_jobs_one(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 04/11] blockdev: add note that block_job_cb() must be thread-safe, Stefan Hajnoczi, 2014/10/01
- [Qemu-devel] [PATCH 05/11] blockjob: add block_job_defer_to_main_loop(), Stefan Hajnoczi, 2014/10/01
- [Qemu-devel] [PATCH 06/11] block: add bdrv_drain(), Stefan Hajnoczi, 2014/10/01
- [Qemu-devel] [PATCH 07/11] block: let backup blockjob run in BDS AioContext, Stefan Hajnoczi, 2014/10/01