Re: [Qemu-devel] [PATCH v4 3/3] pcie: remove confused comments

[Gonglei]

> Subject: Re: [Qemu-devel] [PATCH v4 3/3] pcie: remove confused comments
> 
> On Tue, Sep 30, 2014 at 06:11:26PM +0800, address@hidden wrote:
> > From: Gonglei <address@hidden>
> >
> > The below functions is not allocation functions, but
> > find helper function. The only allocation function is
> > pcie_add_capability(), but its argument names is not the
> > same with the comments. So remove this comments which
> > make people confused.
> >
> > Signed-off-by: Gonglei <address@hidden>
> 
> The comment applies to all functions below it.

This explanation is fine.

> Maybe simply replace
>  s/capability allocation/capability list management/?
> 

Agree.

> Also pls make this a separate patch, does not belong in
> this series.
> 
OK. Will do. Thanks!

Best regards,
-Gonglei

> > ---
> >  hw/pci/pcie.c | 8 --------
> >  1 file changed, 8 deletions(-)
> >
> > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> > index b82211a..f2b9d5d 100644
> > --- a/hw/pci/pcie.c
> > +++ b/hw/pci/pcie.c
> > @@ -528,14 +528,6 @@ bool pcie_cap_is_arifwd_enabled(const PCIDevice
> *dev)
> >          PCI_EXP_DEVCTL2_ARI;
> >  }
> >
> >
> -/**************************************************************
> ************
> > - * pci express extended capability allocation functions
> > - * uint16_t ext_cap_id (16 bit)
> > - * uint8_t cap_ver (4 bit)
> > - * uint16_t cap_offset (12 bit)
> > - * uint16_t ext_cap_size
> > - */
> > -
> >  static uint16_t pcie_find_capability_list(PCIDevice *dev, uint16_t cap_id,
> >                                            uint16_t *prev_p)
> >  {
> > --
> > 1.7.12.4
> >