Re: [Qemu-devel] [PATCH v3 03/23] block: Connect BlockBackend to BlockDriverState

[Markus Armbruster]

Kevin Wolf <address@hidden> writes:

> Am 30.09.2014 um 12:56 hat Markus Armbruster geschrieben:
>> Kevin Wolf <address@hidden> writes:
[...]
>> > Taking back my R-b: You tricked us, this assertion doesn't hold true.
>> > Easy to reproduce by taking a live snapshot. qemu-iotests case 052
>> > catches it. Didn't you run it?
>> 
>> I run "make check-qtest check-block" on every commit before I submit.
>> No idea what went wrong with this one.
>
> When run for raw, it's only 052 that catches it. For qcow2, I got some
> more failures: 039 040 041 051 052 085
>
> I see the problem: Only 039 and 052 are marked as 'quick', i.e. the rest
> is already excluded from 'make check-block'. 039 and 052 don't work with
> cache=none and 'make check-block' uses -nocache, so those are skipped as
> well.

Yes, that's why I missed it.

>       I'll send a patch to remove the -nocache option and let it run
> with the default options.

Appreciated!