[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in tr
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports |
Date: |
Tue, 30 Sep 2014 10:41:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
Il 30/09/2014 08:10, address@hidden ha scritto:
> From: Gonglei <address@hidden>
>
> virtio-$device-{pci, s390, ccw} all duplicate the
> qdev properties of their virtio child. This approach does
> not work well with string or pointer properties since we
> must be careful about leaking or double-freeing them.
>
> Use the QOM alias property to forward property accesses to the
> VirtIORNG child. This way no duplication is necessary.
>
> For their child, object_initialize() leaves the object with a refcount of 1.
> object_property_add_child() adds its own reference which is dropped
> again when the property is deleted.
>
> The upshot of this is that we always have a refcount >= 1. Upon hot
> unplug the virtio-$device child is not finalized!
>
> Drop our reference after the child property has been added to the
> parent.
>
> Changs since v1:
> - add the same handling for virtio-9p-pci device in PATCH 10 and PATCH 11.
> - add a wrapper function for better code sharing
> in PATCH 12 (Cornelia/Michael/Paolo)
I would like to take these patches through the SCSI tree, because of a
small conflict with virtio-scsi dataplane. Any objections?
Paolo
[Qemu-devel] [PATCH v2 02/12] virtio-net: fix virtio-net child refcount in transports, arei.gonglei, 2014/09/30
[Qemu-devel] [PATCH v2 10/12] virtio-9p: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/30
Re: [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports, Cornelia Huck, 2014/09/30
Re: [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports,
Paolo Bonzini <=