qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in


From: Gonglei (Arei)
Subject: Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports
Date: Tue, 30 Sep 2014 00:57:24 +0000

> > > >
> > > > Hm...
> > > >
> > > > void virtio_instance_init_common(Object *proxydev,
> > > >                                  DeviceState *vdev,
> > > >                                  size_t vdevsize,
> > > >                                  const char *vdevname)
> > > > {
> > > >     object_initialize(vdev, vdevsize, vdevname);
> > > >     object_property_add_child(proxydev, "virtio-backend",
> OBJECT(vdev),
> > > > NULL);
> > > >     object_unref(OBJECT(vdev));
> > > >     qdev_alias_all_properties(vdev, proxydev);
> > > > }
> > > >
> > > > and have the initializers call
> > > >
> > > > virtio_instance_init_common(obj, DEVICE(&dev->vdev),
> sizeof(dev->vdev),
> > > > TYPE_WHATEVER);
> > > >
> > > > ?
> > >
> > > OK, it looks good that pass all parameters to one wrapper function.
> > > Will do this in next version.
> > >
> > > Thanks, Cornelia. :)
> > >
> > > Best regards,
> > > -Gonglei
> >
> > I'm fine with doing the cleanup as a patch on top.
> > Cornelia, fine with you?
> >
> 
> Yes, sounds good to me.

Will do, thanks you both!

Best regards,
-Gonglei





reply via email to

[Prev in Thread] Current Thread [Next in Thread]