Re: [Qemu-devel] [PATCH v2 07/17] accel: Make AccelClass.available() optional

[Paolo Bonzini]

Il 29/08/2014 22:31, Eduardo Habkost ha scritto:
> When we move accel classes outside accel.c, the available() function
> won't be necessary anymore, because the classes will be registered only
> if the accelerator code is really enabled at build time.

... which alone is worth the whole series. :)

> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  hw/core/accel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/core/accel.c b/hw/core/accel.c
> index 01cdbc3..483bbe8 100644
> --- a/hw/core/accel.c
> +++ b/hw/core/accel.c
> @@ -82,7 +82,7 @@ int configure_accelerator(MachineClass *mc)
>              fprintf(stderr, "\"%s\" accelerator does not exist.\n", buf);
>              continue;
>          }
> -        if (!acc->available()) {
> +        if (acc->available && !acc->available()) {
>              printf("%s not supported for this target\n",
>                     acc->name);
>              continue;
> 

Reviewed-by: Paolo Bonzini <address@hidden>