Re: [Qemu-devel] [PATCH v2 24/36] s390x: convert s390-virtio to hotplug handler API

[Igor Mammedov]

On Fri, 26 Sep 2014 13:15:16 +0200
Cornelia Huck <address@hidden> wrote:

> On Fri, 26 Sep 2014 09:28:29 +0000
> Igor Mammedov <address@hidden> wrote:
> 
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> > v2:
> >  fix not working unplug
> 
> While the current code for s390-virtio implements unplug, the transport
> per se does not really support unplug (and never has), only hotplugging
> of devices. I removed the ->unplug callback and qemu now behaves like
> I'd expect: I can add devices with device_add, but device_del leaves
> them in place. That would be the way to go for me.
Would a path to remove unplug on top of this one do or you'd prefer
me to respin this patch without unplug?

> 
> > ---
> >  hw/s390x/s390-virtio-bus.c | 12 +++++++-----
> >  1 file changed, 7 insertions(+), 5 deletions(-)
>