[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 12/19] qapi: Add some type check tests
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 12/19] qapi: Add some type check tests |
|
Date: |
Thu, 25 Sep 2014 10:32:58 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 09/25/2014 10:12 AM, Markus Armbruster wrote:
>>> Do we want to permit anything but a complex type for 'returns'?
>>
>> Sadly, yes. We have existing commands that do just that. I already
>> documented that new commands should avoid it (it's not extensible).
>
> If we care, we can whitelist the existing offenders, and reject new
> offenders.
Also a good idea. The whitelist may grow over time, but forcing a
developer to modify the whitelist calls attention to their action :)
I'll add that to my v5 queue. Thanks again for a thought-provoking review.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v4 13/19] qapi: More rigourous checking of types, (continued)
[Qemu-devel] [PATCH v4 19/19] qapi: Drop support for inline subtypes, Eric Blake, 2014/09/19
[Qemu-devel] [PATCH v4 06/19] qapi: Better error messages for bad enums, Eric Blake, 2014/09/19
[Qemu-devel] [PATCH v4 18/19] qapi: Drop inline subtype in query-pci, Eric Blake, 2014/09/19
[Qemu-devel] [PATCH v4 15/19] qapi: Merge UserDefTwo and UserDefNested in tests, Eric Blake, 2014/09/19
[Qemu-devel] [PATCH v4 14/19] qapi: More rigorous checking for type safety bypass, Eric Blake, 2014/09/19