Re: [Qemu-devel] [PATCH 4/4] oslib-posix/win32: convert fprintf/perror to error_report

[Gonglei (Arei)]

> Subject: Re: [Qemu-devel] [PATCH 4/4] oslib-posix/win32: convert 
> fprintf/perror
> to error_report
> 
> On 09/25/2014 03:46 AM, address@hidden wrote:
> > From: Gonglei <address@hidden>
> >
> > Signed-off-by: Gonglei <address@hidden>
> > ---
> >  util/oslib-posix.c | 8 ++++----
> >  util/oslib-win32.c | 2 +-
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> >
> 
> > @@ -380,7 +380,7 @@ void os_mem_prealloc(int fd, char *area, size_t
> memory)
> >
> >      ret = sigaction(SIGBUS, &act, &oldact);
> >      if (ret) {
> > -        perror("os_mem_prealloc: failed to install signal handler");
> > +        error_report("os_mem_prealloc: failed to install signal handler");
> >          exit(1);
> >      }
> >
> > @@ -390,7 +390,7 @@ void os_mem_prealloc(int fd, char *area, size_t
> memory)
> >      pthread_sigmask(SIG_UNBLOCK, &set, &oldset);
> >
> >      if (sigsetjmp(sigjump, 1)) {
> > -        fprintf(stderr, "os_mem_prealloc: failed to preallocate pages\n");
> > +        error_report("os_mem_prealloc: failed to preallocate pages");
> 
> Another reduction in error message quality.  You'll definitely need to
> respin this series, and at this point, I don't know if you can call it
> trivial.
> 
OK. 

Best regards,
-Gonglei

> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org