[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 08/23] block: Eliminate BlockDriverState memb
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 08/23] block: Eliminate BlockDriverState member device_name[] |
|
Date: |
Thu, 25 Sep 2014 13:37:57 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> device_name[] can become non-empty only in bdrv_new_root() and
> bdrv_move_feature_fields(). The latter is used only to undo damage
> done by bdrv_swap(). The former is called only by blk_new_with_bs().
> Therefore, when a BlockDriverState's device_name[] is non-empty, then
> it's been created with a BlockBackend, and vice versa. Furthermore,
> blk_new_with_bs() keeps the two names equal.
>
> Therefore, device_name[] is redundant. Eliminate it.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
- Re: [Qemu-devel] [PATCH v3 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo(), (continued)
- [Qemu-devel] [PATCH v3 04/23] block: Connect BlockBackend and DriveInfo, Markus Armbruster, 2014/09/16
- [Qemu-devel] [PATCH v3 08/23] block: Eliminate BlockDriverState member device_name[], Markus Armbruster, 2014/09/16
- [Qemu-devel] [PATCH v3 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf, Markus Armbruster, 2014/09/16
- [Qemu-devel] [PATCH v3 06/23] block: Make BlockBackend own its BlockDriverState, Markus Armbruster, 2014/09/16
- [Qemu-devel] [PATCH v3 15/23] ide: Complete conversion from BlockDriverState to BlockBackend, Markus Armbruster, 2014/09/16