qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-deb


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info
Date: Thu, 25 Sep 2014 11:36:55 +0100

On 25 September 2014 09:06, Olaf Hering <address@hidden> wrote:
> During code review for xen I noticed that --enable-debug-info would
> still strip the binaries because strip_opt= defaults to yes.
> If --enable-debug-info is passed to configure it has to be assumed
> that not only the compiled binaries have debugsymbols, also the
> installed binaries should keep the symbols. The requirement to pass
> also --disable-strip looks odd.

I think defaulting to build with debug but strip on install
makes sense. It follows for example how Debian recommend
building things:
 https://www.debian.org/doc/debian-policy/ch-files.html
and means that your installed binaries don't have the
extraneous debug info but you can keep the build tree
to make sense of backtraces etc later.

I also prefer configure's options to be orthogonal:
--enable-debug-info should only change how we deal
with debug info, and not also have an effect on whether
we strip it on install. (Plus your patch as it stands
means that the behaviour you get by default now differs
from the behaviour if you explicitly say
--enable-debug-info.)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]